Pass apiResponse along with errors #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This might sound crazy, but should we go through the system-tests and add assertions to test that the proper arguments are being passed in? Otherwise everything looks good to me! |
|
Not crazy! The argument passing is thoroughly tested in the unit tests. We ran into this problem because our unit tests are so decoupled that we stub what The leak was in |
callmehiphop
added a commit
that referenced
this pull request
Jul 24, 2015
Pass apiResponse along with errors
|
👍 thanks! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
* fix: do not import the whole google-gax from proto JS (#1553) fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e * fix(deps): update google-gax Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](googleapis/nodejs-dlp@v4.1.1...v4.2.0) (2022-09-22) ### Features * Add Deidentify action ([#742](googleapis/nodejs-dlp#742)) ([27bb912](googleapis/nodejs-dlp@27bb912)) ### Bug Fixes * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-dlp/issues/1553)) ([#741](googleapis/nodejs-dlp#741)) ([655d6af](googleapis/nodejs-dlp@655d6af)) * Preserve default values in x-goog-request-params header ([#746](googleapis/nodejs-dlp#746)) ([7c53b9f](googleapis/nodejs-dlp@7c53b9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.1](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.0...v4.5.1) (2021-05-20) ### Bug Fixes * **deps:** require google-gax v2.12.0 ([#740](https://www.github.com/googleapis/nodejs-speech/issues/740)) ([0c9c68f](https://www.github.com/googleapis/nodejs-speech/commit/0c9c68f79eee3a9132f0cf18c44a45928da2e809)) * use require() to load JSON protos ([#746](https://www.github.com/googleapis/nodejs-speech/issues/746)) ([689af48](https://www.github.com/googleapis/nodejs-speech/commit/689af48120572779143f16f7d1b0652bdddd931e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [4.5.1](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.0...v4.5.1) (2021-05-20) ### Bug Fixes * **deps:** require google-gax v2.12.0 ([#740](https://www.github.com/googleapis/nodejs-speech/issues/740)) ([0c9c68f](https://www.github.com/googleapis/nodejs-speech/commit/0c9c68f79eee3a9132f0cf18c44a45928da2e809)) * use require() to load JSON protos ([#746](https://www.github.com/googleapis/nodejs-speech/issues/746)) ([689af48](https://www.github.com/googleapis/nodejs-speech/commit/689af48120572779143f16f7d1b0652bdddd931e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As introduced in #706 (comment), this fixes a couple of things:
"Decorate" request options in all cases.
Previously, we were decorating requests only when we were making them automatically for the user. That means our UA header wasn't on the
authorizedReqOptsthat were passed to "onAuthorized(function (authorizedReqOpts) {})". So, this just decorates requests sooner so that anytime we say we "authorized a request", we also put on the UA string and cleaned up gcloud-node-only properties that may have leaked.Pass back apiResponse when there is an error.
All of the callbacks our API accepts are advertised as receiving an "apiResponse" even in the event of an error. The problem was our universal response handler ("util.handleResp") was not giving back the response body if an error was caught, which is what becomes the "apiResponse". So now, it works as advertised.